sulu
Add anchor-field to MediaLinkTypeOverlay
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | sort of |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | fixes #7082 |
| Related issues/PRs | #7082 |
| License | MIT |
| Documentation PR | sulu/sulu-docs# |
What's in this PR?
This PR adds an anchor field to the MediaLinkTypeOverlay (as a copy from the internal link overlay, that already has one).
Why?
As discussed in https://github.com/sulu/sulu/issues/7082 at least for PDF-media an URL fragment can be very useful (to jump to a specific page with #page=12).
Example Usage
Links to a media files (mainly PDF files) can now get an anchor like page=12 within the overlay form (just like links to pages) that is appended to the link's URL like ...longdocument.pdf#page=12.
I didn't find any documentation for the link overlays, so there is no documentation PR,
To Do
Nothing from my point of view. Update: Added a test to cover that field.
Thx, I will update the snapshot tests, mostly a little bit tricky if your system may run on none english system.
