sul-embed icon indicating copy to clipboard operation
sul-embed copied to clipboard

Full-screen behavior in blog posts

Open snydman opened this issue 8 years ago • 2 comments

Expected behavior

For sul-embed viewers embedded in blog posts and other web pages using iFrame, clicking the full-screen control should open the viewer in full screen.

Actual behavior

Clicking the full-screen control only initiates full-screen in the iframe viewport.

Steps to reproduce the behavior

From Ray Heigemeir:

https://library.stanford.edu/blogs/stanford-libraries-blog/2015/10/cavalleria-rusticana-mascagnis-smash-hit

The image viewer is embedded in the post. The full screen toggle opens only as far as the frame allows. This is the function of the frame size, and that "true" full screen cannot be achieved.

Wishlist is for a patron to be able to get to the full screen view from the blog post. I can add a workaround to the blogging instructions that a SW link with "go here for full screen view" may be added to the text. Just want to be sure I'm not missing any fancy tech trick that could make this happen automatically.

Browser / Environment

snydman avatar Mar 02 '18 15:03 snydman

Do we know where Ray got his Embed code from? The code that both the oEmbed API and the UV's Share popup provides all has the allowfullscreen attribute in the <iframe> which allows iframed content to enter fullscreen mode.

The Embed code that is in that blog post does not have that attribute, so it won't be able to enter fullscreen mode (he can easily add that to the iframe code to enable that behavior).

jkeck avatar Mar 02 '18 16:03 jkeck

Perhaps the library website whitelists/blacklists attributes?

cbeer avatar Mar 02 '18 17:03 cbeer

Closing this because the library website is completely different now. We can open a new issue if the current website has the same problem, but as far as I can tell, full screen is working on embeds in the new site. Although I could only find news items with image/book objects so I haven't been able to check all the viewers.

andrewjbtw avatar Jan 28 '25 00:01 andrewjbtw