SearchWorks icon indicating copy to clipboard operation
SearchWorks copied to clipboard

update facet drawer height

Open dnoneill opened this issue 2 months ago • 6 comments

closes #6229 Screenshot 2025-10-07 at 11 47 11 AM Screenshot 2025-10-07 at 11 46 58 AM

dnoneill avatar Oct 07 '25 14:10 dnoneill

I think @dbranchini may have intentionally added the close button in the larger design?

taylor-steve avatar Oct 07 '25 15:10 taylor-steve

@taylor-steve Thanks I missed that. I am assuming this should look the same on medium screens as well?

dnoneill avatar Oct 07 '25 15:10 dnoneill

Is medium the full size side drawer? That seems fine to me but Darcy would the one to say for sure.

taylor-steve avatar Oct 07 '25 15:10 taylor-steve

done and screenshots added

dnoneill avatar Oct 07 '25 15:10 dnoneill

Should the headings be h1? We've got a visually-hidden h1 right above it. Site improve thinks it's fine, WAVE doesn't like it. I don't know if drawers have special considerations?

taylor-steve avatar Oct 13 '25 18:10 taylor-steve

Per SODA, WAVE complains with more false positives than the other scanning tools because it scans hidden elements. We should use the same pattern here as we do for modals, and we use H2s for modals.

As far as medium sized, this is what I designed and it seems that was implemented, so we shouldn't have drawers on that size.

dbranchini avatar Oct 16 '25 18:10 dbranchini