SearchWorks icon indicating copy to clipboard operation
SearchWorks copied to clipboard

Use friendly library names in page title

Open marlo-longley opened this issue 5 months ago • 5 comments

Fixes #5825

marlo-longley avatar Jul 25 '25 19:07 marlo-longley

Is there no hope doing this upstream/when we're initially constructing the text?

cbeer avatar Jul 25 '25 20:07 cbeer

https://github.com/projectblacklight/blacklight/blob/d241cbbd27d0b223b48285e9bb229886bffb6a5a/app/helpers/blacklight/catalog_helper_behavior.rb#L131 This is my read on where the text is being constructed.

Since BL doesn't know about our Stanford library codes I am not sure.

marlo-longley avatar Jul 25 '25 20:07 marlo-longley

I looked into this a little bit and to fix it we would need to override the facetfieldpresenter. Honestly I think this really an issue in upstream blacklight. We have a helper method on the facet which is how the library is showing up with the right information right now. The title shouldn't ignore the helper on the facet. I am going to look around upstream and see if we can get it fixed there.

dnoneill avatar Jul 30 '25 15:07 dnoneill

So blacklight doesn't ignore helper methods. I think it might be a bug in one of our overrides that is causing the problem. I can't quick figure out the problem though. Might be something for the next wc

dnoneill avatar Jul 30 '25 16:07 dnoneill

Thanks for looking into this Niqui -- happy to discuss more

marlo-longley avatar Jul 30 '25 17:07 marlo-longley