SearchWorks icon indicating copy to clipboard operation
SearchWorks copied to clipboard

add eds_pub_date facet

Open dnoneill opened this issue 7 months ago • 3 comments

closes #1832 needs https://github.com/ebsco/edsapi-ruby/pull/131 to work

Screenshot 2025-05-22 at 12 22 49 PM Screenshot 2025-05-22 at 12 22 36 PM

dnoneill avatar May 20 '25 19:05 dnoneill

Screenshots look good. Thank you!

dbranchini avatar May 22 '25 16:05 dbranchini

@dbranchini : are radio buttons the right affordance for this, or would it be better to treat them as regular facet links? With the radio buttons, it seems a little harder to escape from that context and get back to using the date slider (and.. are optional radio buttons even ok?)

cbeer avatar May 22 '25 17:05 cbeer

I'm not sure what you mean by "optional radio buttons"? (I assume they work as a group and you can only select one.) I noticed the radio buttons when Niqui implemented it. I think they're appropriate, but probably better if all of our facets were either radio buttons or checkboxes or none at all. Since I didn't give her much guidance to begin with, initially I thought I'd let it go. BUT this is probably the right time to fix it. Let's go with a standard facet link since that's what we use everywhere else.

dbranchini avatar Jun 05 '25 20:06 dbranchini