Missing PAGE request links on L-PAGE-EA

[saseestone]

East Asia public services staff reported that Request links are not appearing on materials with Library = SAL and Home Location = L-PAGE-EA. Request links should appear for this location regardless of library.

As far as I can tell, the Location is listed in our constants file as pageable for SAL: https://github.com/sul-dlss/SearchWorks/blob/511930198c115b9c872d37815bc5aea5d26acda3/config/settings.yml#L273

I can't see that the Item Type = LCKSTK is coming into play but 🤷🏽

Example record: https://searchworks.stanford.edu/view/6540685

[saseestone]

I'll do a check to see if we're missing links on any other SAL locations.

[corylown]

LCKSTK is not included among the circulating item types for SAL in Settings, which if I'm reading the code correctly, is required for the request button to show up: https://github.com/sul-dlss/SearchWorks/blob/511930198c115b9c872d37815bc5aea5d26acda3/config/settings.yml#L468

[corylown]

Just confirmed that adding LCKSTK to the list of circulating item types for SAL allows the request button to show up for this record. I am not sure whether LCKSTK items are supposed to be requestable though: http://sw-webapp-stage-a.stanford.edu/view/6540685

[saseestone]

I'm doing a few checks to:

1. ensure we're ok to enable LCKSTK (and public services staff are prepared for that)
2. make sure we don't have more item types (or locs) that need to be enabled

I did see the "circulating_item_types" list, but thought it was related to icons. If this list governs only Request links, we might want to rename it to "pageable_item_types". (or better yet...reqeustable_item_types.)

[cbeer]

circulating_item_types is also used to determine whether to show item-level request links for hold/recall.