vscode-audio-preview icon indicating copy to clipboard operation
vscode-audio-preview copied to clipboard

Feature player filter

Open kashiken opened this issue 8 months ago • 7 comments

This PR introduces a filter function for the player.

Purpose of Change

  • To allow the user to preview the audio more precisely.
    • For audio recording use cases, the user can focus on or remove unwanted noise.
    • For music listening use cases, the user can focus on a specific instrument or vocal.

Changes

  • Added bi-quad filters for playback audio path.
    • The added filters are only inserted into the path when enabled.
  • Added PlayerSettingsComponent to set the filter enable and the cutoff frequencies.
    • The user can enable the high-pass and low-pass filters individually.
    • The user can also set the cutoff frequencies.
    • By selecting the "match to spectrogram frequency range" option, the cutoff frequencies automatically match the analyzer frequency range.
      • The user can select the frequency range to preview visually by selecting a range on the spectrogram.

pr_player_filter

Tests

  • I've confirmed the changes visually, and tested the UI operations as well.
  • Some tests have been added to test the new component and settings.
  • The changes conform to all existing tests.

Notes

  • This PR includes the fix of const declaration which I was mentioned in #57.
  • I replaced some "playerSettingService" to "playerSettingsService" for consistency.

kashiken avatar Jun 16 '24 14:06 kashiken