sukeesh
Clean up plugins, better code formatting + more polished features
I was going through the plugins and noticed that they could certainly do with better formatting, better code, and a lot of polish for features. The motivate me plugin, for example, has strangely formatted code, and some grammatical errors. The tic tac toe doesn't describe how to play the game, and one has to guess that the number keys would do that.
I could help clean up these things.
Hi @Milind220 is anyone actively working on this? I'm taking a Software Development Methodology course at University right now, and one of our projects is to make meaningful contributions to opensource projects. Could I be assigned this one? I have experience building tic tac toe and connect 4 board games.
Just read CONTRIBUTIONS.md. I'll be working on this one. Will post updates here throughout my work over the next two months.
@pnhofmann are there any specific plugins I should be reformatting? I have updated the tic tac toe to give clearer instructions. Have been considering implementing a connect 4 game as well.
Hey, Actually no, nothing specific I could think of right now. But connect 4 game would be nice ;). And you can already create a PR for your tic tac toe update - creating multiple PR each with one addition is usually preferred over one PR with lots of (different) stuff. Best Regards, Philipp Hofmann
On 2022-02-08 22:08, Troy Phillips wrote:
@pnhofmann [1] are there any specific plugins I should be reformatting? I have updated the tic tac toe to give clearer instructions. Have been considering implementing a connect 4 game as well.
-- Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. Triage notifications on the go with GitHub Mobile for iOS [4] or Android [5]. You are receiving this because you were mentioned.Message ID: @.***>
Links:
[1] https://github.com/pnhofmann [2] https://github.com/sukeesh/Jarvis/issues/913#issuecomment-1033063297 [3] https://github.com/notifications/unsubscribe-auth/AHLI4YEHUEW3QQKIK7BZOHTU2GA5BANCNFSM5HYQAFGQ [4] https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 [5] https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
There wasn't much to change for plugin formatting. Submitting a PR for updated connect 4 instructions. Will create a new feature issue for the connect 4 game @pnhofmann
This is complete, and has been covered in a pull request. Can we update this to closed?