New feature: Pokemon

[cpd67]

Hello! First off, I'd like to say that this is a really cool project! I've been looking for something like this that I could use as well as contribute to, and i'm glad I found it. :smile:

With that said, I've created a new plugin that allows Jarvis to give information about a specific Pokemon. It adds the pokemon command, and users can say the name of the Pokemon they want to know more about. For example, pokemon zapdos will result in Jarvis giving information about Zapdos. The name, generation, description, and whether or not the Pokemon is mythical or legendary is given. Here's a screenshot of it in action:

The plugin uses the PokeAPI REST API to obtain information about the requested Pokemon. It currently displays the information in English, though I think it would be nice to display in other languages.

I also fixed linting errors that I saw in the Travis build logs.

[pnhofmann]

Hi! Hmm, tricky... This data from PokeAPI is from original Pokemon Games and therefore Copyright protected. According to https://github.com/veekun/pokedex:

This repository includes data extracted from the Pokémon series of video games. All of it is the intellectual property of Nintendo, Creatures, inc., and GAME FREAK, inc. and is protected by various copyrights and trademarks. The author believes that the use of this intellectual property for a fan reference is covered by fair use — the use is inherently educational, and the software would be severely impaired without the copyrighted material.

That said, any use of this library and its included data is at your own legal risk.

Fair use is an US law, that does not apply to other countries.

Tricky, because your code does not contain any copyright protected material; but I think we would need at last something like above disclaimer; but I'm still not 100% sure...

[cpd67]

Good point, I had not thought of that. I could add that disclaimer as warning text before printing out the Pokemon fact. Something like:

DISCLAIMER: This Pokemon fact is the intellectual property of Nintendo, Creatures, inc., and GAME FREAK, inc. and is protected by various copyrights and trademarks. This use is soley for educational purposes to learn more about Pokemon.

// Pokemon fact...

[cpd67]

I've added some disclaimer text before the Pokemon fact:

[cpd67]

@pnhofmann Could you take a look at my changes?

[pnhofmann]

Hi, finally I'm back (had lots of work to do). Maybe this would be a candidate for #801 ?