rc-switch icon indicating copy to clipboard operation
rc-switch copied to clipboard

Enhancements to support many more switches and RF433 units.

Open perivar opened this issue 7 years ago • 3 comments

Hi sui77, thanks alot for a brilliant library! I struggled to make the library work with some Everflourish and Nexa units (sold a lot here in Scandinavia) and through debugging I found out that the problems was the limitation of only having 32bit codes. Therefore I extended the functionality to include longer bitstrings. There was also a limitation related to how long a "pause" signal can be which I fixed. (you called it sync, while sync is for me the sync bits in the beginning of of a transmission). This has now been tested by myself and a few others for the ST_Anything project where I run RC-switch on a NodeMCU to act as a bridge for my SmartHome system. I also like PlatformIO (in Visual Studio Code) alot, so that has become my IDE of choice and the projects are made to work in this IDE. See https://github.com/perivar/ST_Anything_NodeMCU/tree/master/lib/ST_Anything_RCSwitch and https://github.com/perivar/rcswitch-testing

Cheers, Per Ivar

perivar avatar Feb 13 '18 14:02 perivar

Hello @perivar,

I'm not a maintainer but an interested user.

I noticed you point Travis (in the README.md) to yourself. This should be cleaned up before a merge here. I also noticed that you introduced a lot of style changes which makes reading the diffs hard.

I suggest you to create a separate branch for the PR, so that you can use your own master independently. Then you could clean up the branch (with an interactive git rebase) where you maybe group some related commits together and either avoid or separate the style changes.

One last thing: how does the F macro behave on other hardware than the Arduino? I guess it wouldn't make much sense on e.g. a RaspberryPi. Which reminds me of #64 as RaspberryPi builds still aren't tested by Travis.

Locke avatar Feb 16 '18 12:02 Locke

Related #124

jrc avatar Jul 11 '20 18:07 jrc

It's been a while, but it would be nice to see this merge. It adds support for countless more remotes and protocols by supporting the pause/second sync bit. In fact, due to this, I was able to support 2 of my remotes at home. I am also trying to implement these changes in the ESPHome version of RC-Switch so I can connect all my remotes there too.

Hopefully someone who maintains this can take a look and consider merging into the main project though.

Priva28 avatar Nov 23 '20 02:11 Priva28