clickhouse-rs icon indicating copy to clipboard operation
clickhouse-rs copied to clipboard

Support for the Map data type

Open shenghaoyang opened this issue 3 years ago • 4 comments

Hello,

Thanks for the crate!

Are there any plans to add support for Maps to the library? I'm trying to use that for dynamic data to get away from stuffing a map-like object as a string / etc.

Trying to figure out how to get started on that - does anyone have any good ideas?

Relevant documentation:

  • Data type reference: https://clickhouse.tech/docs/en/sql-reference/data-types/map/
  • Map functions: https://clickhouse.tech/docs/en/sql-reference/functions/tuple-map-functions/

shenghaoyang avatar May 31 '21 17:05 shenghaoyang

I am working on a map implementation

petar-dambovaliev avatar May 02 '22 17:05 petar-dambovaliev

@suharev7 the error handling in this library is not good. A lot of places just tell you ops, an error. It doesn't tell you what is the wrong value/type you gave and what are the correct ones. This also needs to be fixed because working on it is painful.

petar-dambovaliev avatar May 04 '22 10:05 petar-dambovaliev

Thanks for the comment, but I would appreciate it if you could point out specific cases where you lacked some information about error.

suharev7 avatar May 04 '22 21:05 suharev7

Thanks for the comment, but I would appreciate it if you could point out specific cases where you lacked some information about error.

For example, Err(Error::FromSql(FromSqlError::OutOfRange)); When i had a typo in the column i want to get, it didn't tell me which value was no existing and which values were available.

petar-dambovaliev avatar May 04 '22 23:05 petar-dambovaliev