aigle icon indicating copy to clipboard operation
aigle copied to clipboard

Published 20 hours ago • verified publisher icon suguru03

Suggestions: Add Typescript Types

Open nkrass opened this issue 6 years ago • 4 comments

Hi @suguru03 have u thought about adding typescript types for the project?

nkrass avatar Sep 15 '17 02:09 nkrass

Hi @nkrass ! It is a good idea, but I'm not familiar with TypeScript. I'll look into it, thanks! 😄

suguru03 avatar Sep 15 '17 07:09 suguru03

+1 it is better to just write the library in TS. TS is not hard - it's very similar to JS. I can help you convert to TS, I am very good with TS.

If you write the lib in TS, it's a big advantage and some people will prefer to use Aigle instead of Bluebird for that reason. Same goes for neo-async :)

ORESoftware avatar Feb 01 '19 08:02 ORESoftware

@ORESoftware Thanks for the suggestion! It is a great idea, I also love TypeScript! But I'm planning to apply big changes, so I need to investigate the conversion. ✍️

For now, I added some types here ( I need to add more...! ) https://github.com/suguru03/aigle/blob/master/typings/aigle.d.ts It is released from v1.13.0, please try it! 😄

suguru03 avatar Feb 01 '19 18:02 suguru03

Yeah TS will help you maintain the library - with types, small and big changes are easier. Looks like you picked up TS - those types look really good - but I think it's better to just write the library itself in TS, that way the types and the library are always in sync

ORESoftware avatar Feb 01 '19 21:02 ORESoftware