gotch icon indicating copy to clipboard operation
gotch copied to clipboard

Published 20 hours ago • verified publisher icon sugarme

added normal Glorot initialization

Open vcadillog opened this issue 2 years ago • 2 comments

Hi, great work with this golang binding; I was translating my code for production but I saw the xavier_normal_ method was missing. Hope this can help other people who had encountered this issue.

vcadillog avatar Oct 15 '23 16:10 vcadillog

@vcadillog ,

Thanks for the PR. Please see my comments/wishes above. Would love to have this contribution. Please take your time.

sugarme avatar Oct 15 '23 20:10 sugarme

Yes, I noticed that Glorot initialization needed to be implemented; and also I'm not quite sure if I should use lowercase because the xavier_uniform_ is defined as XavierUniform_ in the binding; but if you are referring to the glorotNInit, yes; I'll make sure to use lowercase.

vcadillog avatar Oct 16 '23 13:10 vcadillog