musicblocks icon indicating copy to clipboard operation
musicblocks copied to clipboard

fix: simultaneous opening of Pitch Pie Menu and Grey Menu on Right Click

Open haroon10725 opened this issue 5 months ago • 15 comments

I found that this.container has both an on-click and a press-up event listener: The on-click listener checks if the Ctrl key is pressed. If it is, it triggers the piemenuBlockContext function, which displays a grey menu. After this, the function returns, preventing any further code from executing. The press-up listener calls the _mouseoutCallback function, but only if that.blocks.getLongPressStatus is false. This ultimately triggers the _changeLabels function without checking whether the Ctrl key is pressed or not.

@walterbender Can you please review it ?

haroon10725 avatar Sep 17 '24 12:09 haroon10725