musicblocks icon indicating copy to clipboard operation
musicblocks copied to clipboard

dismissing an error message removeArrow() is not found

Open Traitor000 opened this issue 2 years ago • 2 comments

Steps to recreate :-

create a note with 4/1 as its note value. when you play it, a warning message appears. click on the x to dismiss the message... the arrow will not be removed.

image

Traitor000 avatar Aug 22 '22 21:08 Traitor000

closed in #3067 connected to #3065

Traitor000 avatar Aug 29 '22 10:08 Traitor000

the error with the arrow, it can be triggered by any error message, so, no, it is not yet resolved.

Traitor000 avatar Aug 29 '22 12:08 Traitor000

Can You please Elaborate on the place where it should be done? I want to contribute to this issue.

AnkanSen avatar Jan 12 '23 08:01 AnkanSen

I couldn't find the problem, followed your steps

ManavSarkar avatar Jan 22 '23 04:01 ManavSarkar

@Traitor000 plz assign this to me , I had already done this same functionality back on my hackathon project and quite familiar with it how it's done. Thanks

image

IayushCoderJOD avatar Jan 29 '23 13:01 IayushCoderJOD

I didn't get what you want the program to do. Should the arrows be removed as soon as the 'X' button is hit or something else?

shashank022002 avatar Jan 29 '23 16:01 shashank022002

I have played note value 4/1 but i did not get any kind of warning message.

Keerthivardhan1 avatar Feb 04 '23 15:02 Keerthivardhan1

hideArrowsProblem It seems like if you cancel any warning sign it can't find the "hide Arrows" function and couldn't remove arrows.

hideArrowsCodeSolve2 it seems like on "activity.js" "hideArrows" variable is defined but index.html can't access the function type variable. And this pis of code would solve the problem : // window.hideArrows = hideArrows; //

nahianhasan161 avatar Feb 04 '23 19:02 nahianhasan161

Hey @Traitor000, I've made a Pull Request. Could you see it, please?

Vivekk-11 avatar Feb 06 '23 04:02 Vivekk-11

Hi, Can I please help you in fixing it? I have good knowledge of JS and web-dev.

Jastagar avatar Feb 07 '23 14:02 Jastagar

@Traitor000 Should I work on it if it's still not resolved? Please assign this issue to me!

ashutosh887 avatar Feb 25 '23 16:02 ashutosh887

so can i help you in this i have a good amount of knowledge

priyangshusarkar77 avatar Feb 26 '23 16:02 priyangshusarkar77

i wanna help you in solving this issue.

Chiragmanral avatar Feb 27 '23 16:02 Chiragmanral

i am not having the issue just i am asking in github that if u have any doubt just ask me

On Mon, Feb 27, 2023 at 9:37 PM Chiragmanral @.***> wrote:

i wanna help you in solving this issue.

— Reply to this email directly, view it on GitHub https://github.com/sugarlabs/musicblocks/issues/3066#issuecomment-1446606028, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARJOPW75TPEWIT2EA55RE73WZTGN5ANCNFSM57JFVVYA . You are receiving this because you commented.Message ID: @.***>

priyangshusarkar77 avatar Feb 27 '23 16:02 priyangshusarkar77

@Traitor000 and @walterbender could you review this pull request, it solves the issue to the best of my knowledge

the error message 2

After dissiming the error message 3

shahkushal38 avatar Mar 24 '23 18:03 shahkushal38

i'd love to work on this issue or help and collaborate with whoever is working on it

Aryan-Mishra24 avatar Apr 02 '23 23:04 Aryan-Mishra24

I think this issue is fixed.

walterbender avatar Apr 03 '23 12:04 walterbender

hey there, i would like to work this issue

zahidhussain998 avatar Oct 04 '23 14:10 zahidhussain998