Enhancement to full screen functionality of widgets

[ksraj123]

Currently only a few widgets make good use of the extra space in full screen mode. Ideally we want the fullscreen mode to be meaningful for all widgets, however for some widgets fullscreen mode does not bring any benefits and for them the same could be disabled. Since we are moving to music blocks 2 widgets that require too much work to be adapted to the fullscreen mode could be left out.

Widgets whose fullscreen mode could be enhanced

• [x] status - completed
• [x] mode - completed #2894 - contents should be scaled in fullscreen mode, this could be helpful in some cases as interactive elements in this widget ad small and close together
• [x] meter - completed #2771 - contents should be scaled
• [x] oscilloscope - completed #2892 - would be nice to see the graph in greater detail in fullscreen mode
• [ ] Pitch drum matrix - under development - contents should be scaled in fullscreen mode, interactive items are small and close together
• [x] Rhythm ruler - completed #2895 - smaller sections of the ruler could be easily worked with in full screen mode
• [x] statistics - completed #2893 - would be nice to see the scaled graphs clearly in full screen mode
• [ ] temperament - under development

Widgets for which fullscreen mode should be disabled

• [x] help - completed #2877 - windows are usually large enough to accommodate help content, we might scale the images and text in the fullscreen mode but that would not good look or serve any real purpose in my opinion.
• [x] tempo - completed #2877 - argument in favour of full screen mode could be that one might get more granular control over changing beats by click with a wider track on the fullscreen mode but we have a text input for that.
• [x] pitch slider - completed #2877 - a longer slider in fullscreen mode would give more control but since most of screen space gained would not be of any use I think we would be better off implementing text box for entering pitch as in tempo.
• [x] pitch staircase - completed #2877 - scrolling should be enabled for this widget, the widget window grows as items are added, eventually it grows out of the screen and there's no way to access the items at the bottom of the widget window.
• [x] timbre - completed #2877 - scrolling works fine and nothing meaningful could be scaled in the fullscreen mode for this in my opinion

Widgets which should be left as they are

• music keyboard
• phrase maker

References: https://github.com/sugarlabs/musicblocks/issues/2761#issuecomment-766138220

Please share feedback and suggestions.

[ksraj123]

@meganindya Please share your opinions on this classification. Thanks

[meganindya]

The matrix in the Music Keyboard could be appropriately sized. There is free space at the bottom. Should be an easy fix.

[daksh4469]

Hey @ksraj123 @meganindya, can we add the feature to maximize the widget on Double-Clicking the top-bar of the widget....just as in Windows and Ubuntu systems? If yes I would like to add this.

[daksh4469]

Hey @meganindya... Can you check if PR #2841 satisfies what you have mentioned in the above comment? It is currently generating linting errors and I am working towards linting the file.

[daksh4469]

Hi @ksraj123, can we also enhance the full-screen functionality of the phrasemaker widget by utilizing the blank space just as in musickeyboard widget? Please share your opinion on this. Thanks.

[ksraj123]

@daksh4469 We could do that but I don't think there's really a need for that because unlike the music keyboard, the widget window for phrasemaker expands to accommodate all the rows n columns even in non-fullscreen mode, which makes the fullscreen mode useful for very few use cases where the matrix is too large to fit on the screen. Scaling the cells themselves in fullscreen mode would not be a good idea as the number of rows n columns are not fixed. But we should enable horizontal and vertical scrolling in fullscreen mode if the table is overflowing which should be an easy fix. Please share your thoughts on this @meganindya

[khushal87]

@ksraj123 Any widget which I can pick to work on? Thanks.

[ksraj123]

@khushal87 Since this issue is somewhat old, most of the widgets are done. Either the fullscreen functionality is already implemented, or is under review or is lying in local awaiting some finishing touches. Will be opening PRs for pitchDrumMatrix and temperament soon as they are almost done, after the current PRs are merged. Please feel free to explore MusicBlocks and look for issues. Thanks

[khushal87]

@khushal87 Since this issue is somewhat old, most of the widgets are done. Either the fullscreen functionality is already implemented, or is under review or is lying in local awaiting some finishing touches. Will be opening PRs for pitchDrumMatrix and temperament soon as they are somewhat done, after the current PRs are merged. Please feel free to explore MusicBlocks and look for issues. Thanks

I checked widgets like "custom mode" and "tempo" and they seem unscaled in full-screen mode. Are they ought to be the same?

[ksraj123]

@khushal87 custom mode is currently under review in PR #2894 and for the tempo fullscreen mode was disabled for the reasons mentioned in the starting comment of this issue.

[khushal87]

@kushal87 custom mode is currently under review in PR #2894 and for the tempo fullscreen mode was disabled for the reasons mentioned in the starting comment of this issue.

Okay. Thanks, will check some other issue.

[Adityakushwaha142]

Is this issue is resolved . can i start working on this issue

[AakashKota]

Hi I am new to the Opensource Coding and would like to start my journey with this organisation. I am well versed with Python, Html, Java CSS, Django Frame work. I need guidance for the same. Thanks in advance.

[ashutosh887]

@ksraj123 Should I work on it if it's still not resolved? Please assign this issue to me!

[aditya-mistri]

@ksraj123 please assign me this issue : Pitch drum matrix I think I can solve this

[yashpandey06]

if its not resolve please assign this issue to me

[walterbender]

We have the ability to go full screen now and perhaps some widgets could take better advantage of the additional screen real estate. But we can tackle them individually in new tickets.