musicblocks icon indicating copy to clipboard operation
musicblocks copied to clipboard

No Wrapping in arc - Graphics

Open ksraj123 opened this issue 4 years ago • 5 comments

Forward Block has wrapping (when the turtle goes out of screen bounds) but arc block has no wrapping. This could lead to the turtle getting lost in some situations. It would be better #2750 Proposes a block to enable or disable wrapping, Ideally, we should have wrapping on both forward and arc blocks and the user should be able to enable or disable wrapping.

no_warp_in_arc

Is this a possible enhancement or it is intentionally made this way?

Thanks, Please share your feedback and suggestions.

ksraj123 avatar Jan 15 '21 15:01 ksraj123

@walterbender @pikurasa @meganindya can you please have a look and share your thoughts on this. Thanks

ksraj123 avatar Jan 16 '21 13:01 ksraj123

It makes sense to have wrapping enabled for arc. While we are on the topic, we prob. want to turn off wrapping in the middle of a fill.

walterbender avatar Jan 18 '21 22:01 walterbender

@walterbender sure, it seems reasonable to disable wrapping when drawing for filling. The below screenshot compares the current situation with what is wanted, is this the kind of functionality we are looking for regarding this? changes

ksraj123 avatar Jan 19 '21 02:01 ksraj123

Yes. That's correct

On Mon, Jan 18, 2021, 9:08 PM Kumar Saurabh Raj [email protected] wrote:

@walterbender https://github.com/walterbender sure, it seems reasonable to disable wrapping when drawing for filling. The below screenshot compares the current situation with what is wanted, is this the kind of functionality we are looking for regarding this? [image: changes] https://user-images.githubusercontent.com/39027928/104978562-186e3700-5a28-11eb-9d1e-564b314a8a1f.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sugarlabs/musicblocks/issues/2754#issuecomment-762554592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6PXYJ4T2WMD2QJY2L6AXLS2TSSRANCNFSM4WEGABXA .

walterbender avatar Jan 19 '21 02:01 walterbender

@walterbender opened a PR #2765 addressing the wrapping in the middle of fill issue. Please have a look. Thanks

ksraj123 avatar Jan 20 '21 04:01 ksraj123