musicblocks icon indicating copy to clipboard operation
musicblocks copied to clipboard

Add JSDoc style documentation

Open meganindya opened this issue 4 years ago • 21 comments

Add JSDoc style documentation when adding new functions, classes, etc. They help the linter.

We should eventually have everything documented in that manner. Perhaps, at some time in the future we might explore porting to TypeScript, thus increasing the robustness and reliability of the codebase.

meganindya avatar Nov 28 '20 05:11 meganindya

Sir,for this issue we have to configure the project with JSDoc 3 or do commenting on functions and classes to make batter documentation(it is already configured with JSDoc). @meganindya

sj00coder avatar Nov 28 '20 08:11 sj00coder

Add comments as

/**
 * @param ...
 * @returns ...
 * @throws ...
 * 

meganindya avatar Nov 28 '20 08:11 meganindya

On ever javascript file ,on all functions and classes? @meganindya

sj00coder avatar Nov 28 '20 08:11 sj00coder

anywhere applicable

meganindya avatar Nov 28 '20 10:11 meganindya

some files have

/*
 * @param ...
 * @returns ...
 * @throws ...
 * 

so just gotta add an *

meganindya avatar Nov 28 '20 10:11 meganindya

I am really sorry,but I cant understand that.But,I really want to work on it Sir.Actually,the documentation of jsdoc is also not so clear. In the,below image,where you want to add * image Or change it in the form like below image. image

sj00coder avatar Nov 28 '20 11:11 sj00coder

this

image

Change /* ... */ to /** ... */

meganindya avatar Nov 28 '20 11:11 meganindya

ohk sir,thank you.I'll do that

sj00coder avatar Nov 28 '20 11:11 sj00coder

Is this issue still open? I would like to contribute to it.

nikkuAg avatar Jan 13 '22 15:01 nikkuAg

@walterbender @Gautam-Hegde Should I work on it if it's still not resolved? Please assign this issue to me!

ashutosh887 avatar Feb 25 '23 16:02 ashutosh887

We don't assign issues, but feel free to make a PR.

walterbender avatar Feb 25 '23 19:02 walterbender

Is this issue still open @walterbender @meganindya ?

Thanks and Regards

ojuschugh1 avatar Apr 21 '23 17:04 ojuschugh1

I assume there are still a few situations where it needs updating.

walterbender avatar Apr 21 '23 18:04 walterbender

I assume there are still a few situations where it needs updating.

Yes, I saw the codebase, there are some areas which need this update. I have made a PR regarding this. If the changes I made are correct, I can proceed further making more changes

Karan-Palan avatar Dec 08 '23 05:12 Karan-Palan

Is this issue still open? @walterbender I would like to contribute.

Ritika-K7 avatar Jan 16 '24 14:01 Ritika-K7

There may still be a few places where the docs need updating. But please don't duplicate the work from this as-of-yet unmerged PR: https://github.com/sugarlabs/musicblocks/pull/3433

walterbender avatar Jan 16 '24 14:01 walterbender

Okay sir.

Ritika-K7 avatar Jan 16 '24 15:01 Ritika-K7

@walterbender I hope this message finds you well. My name is Ritika

JSDoc style documentation I made the changes like this .

Screenshot 2024-01-17 161426 I've encountered an issue while attempting to push a new branch with my changes to the repository. Unfortunately, I'm getting a "Permission Denied" error.

Here are some additional details:

  • GitHub Username: Ritika-K7
  • Repository: musicblocks
  • Branch: featureMB

Could you please review my permissions and assist in resolving this issue?

Thank you for your time . I appreciate your help in resolving this matter.

Best regards, Ritika

Ritika-K7 avatar Jan 17 '24 11:01 Ritika-K7

@walterbender I hope this message finds you well. My name is Ritika

JSDoc style documentation I made the changes like this .

Screenshot 2024-01-17 161426 I've encountered an issue while attempting to push a new branch with my changes to the repository. Unfortunately, I'm getting a "Permission Denied" error.

Here are some additional details:

  • GitHub Username: Ritika-K7
  • Repository: musicblocks
  • Branch: featureMB

Could you please review my permissions and assist in resolving this issue?

Thank you for your time . I appreciate your help in resolving this matter.

Best regards, Ritika

I guess you haven't forked the project and are making commits directly to this repository. Please fork and then commit your changes

Karan-Palan avatar Jan 17 '24 11:01 Karan-Palan

okay sir thank you.

Ritika-K7 avatar Jan 17 '24 11:01 Ritika-K7

okay sir thank you.

I am just a freshman and a fellow contributor, so no need to call Sir. Glad I could help

Karan-Palan avatar Jan 17 '24 12:01 Karan-Palan