let there be let

[walterbender]

Now that ECMA is ubiquitous, there is no longer any reason to not use let instead of var where appropriate. It is a fairly major change -- we need to be careful regarding scoping. But nonetheless, it is time.

• [ ] js/
• [x] js/widgets/
• [x] js/blocks/ <-- mostly already in place
• [x] js/utils
• [x] planet/

[Ishakikani9117]

I will be working on this issue.

[Tobenna-KA]

I will be working on this issue.

Already started, this is actually in reply to the commit I made. Maybe we can talk about how to share the work, so we don't spend time working on the same things?

[Ishakikani9117]

@Tobenna-KA ohh. same here. I also already started. Which part are you doing right now?

[Tobenna-KA]

@Ishakikani9117 I was heading into js/

[Ishakikani9117]

@Tobenna-KA great , I was doing blocks and i will be heading to widgets and utils.

[Tobenna-KA]

Alright, sounds good, I will do the work on what is outside those 3 folders within /js

[aviral243]

@walterbender Should we also try moving towards Arrow functions as there are numerous instances where this binding has been an issue, in the entire code. We can get rid of them using Arrow functions.

[walterbender]

yes... we can use arrow functions in a lot of places.

[aviral243]

@walterbender Will create a new issue and start working on it ASAP.

[meganindya]

@Ishakikani9117 @Tobenna-KA no offense. But, please be careful with the variable scopes while replacing var with let. I'm sure you know that let, unlike var, has a block only scope.

Here is an example. #2214 is caused by such a mistake. See the following excerpt in FlowBlocks.js:

[Tobenna-KA]

@Ishakikani9117 @Tobenna-KA no offense. But, please be careful with the variable scopes while replacing var with let. I'm sure you know that let, unlike var, has a block only scope.

Here is an example. #2214 is caused by such a mistake. See the following excerpt in FlowBlocks.js:

I'm pretty sure we both know this, and at least with the changes I have made in cases like this, you'd see me moving variable declarations out of the scope to a more global position to allow the use of let rather than var, but if necessary leave the var declaration.

But thank you for your concern.

[aviral243]

@Tobenna-KA Are you working on the remaining files inside js/ folder? Once they're done I can resume working on #2201

[meganindya]

@Tobenna-KA great , I was doing blocks and i will be heading to widgets and utils.

@Ishakikani9117 I was recently working on quite a few issues with the phrase maker (widgets/pitchtimematrix.js). There's one I'm currently working on and it might require changes at several places. So, can you please leave out that file for the time being? After the issue is sorted, I can help with the replacements by let and arrow functions for that file, since I'm somewhat versed with its contents.

[Ishakikani9117]

@meganindya Ok. I will leave that file.

[Tobenna-KA]

@Tobenna-KA Are you working on the remaining files inside js/ folder? Once they're done I can resume working on #2201

Yes I am

[b18050]

@meganindya @Ishakikani9117 @Tobanna-KA Is anyone doing changes to planet. I want to work on this if anyone has not yet started on this.

[Ishakikani9117]

@b18050 I want to do the planet folder.

[meganindya]

@walterbender I've reviewed pull requests for changes in planet/ (#2231) and js/utils (#2225, #2226). Please take a look.

[walterbender]

The bulk of the work remaining is with the widgets.

[walterbender]

While I marked this as a "Good first issue", please bear in mind: (1) global replace will undoubtedly break the code so please don't; (2) please test after making your changes.

[ricknjacky]

While I marked this as a "Good first issue", please bear in mind: (1) global replace will undoubtedly break the code so please don't; (2) please test after making your changes.

@walterbender remaining files of js/widgets have been cleaned up, and both the guidelines were kept in mind while doing so.

[blank-27]

can i work on this issue ?

[meganindya]

The js/ directory is the priority. Only 5 effective occurrences remain, probably corner cases. You may try #2629.

[blank-27]

ohk thanks

[Ayush-Khandelwal-007]

Please allow me to further clean it up in the remaining files.

[S-kus]

@walterbender @meganindya is there any work still pending?