Suhas Karanth

Results 82 comments of Suhas Karanth

I think it is very hard to categorically identify the better solution because on some level, they are all essentially the same. What we are discussing are very minor implementation...

Sure @okonet since 2 of us prefer `includes` and `excludes`, I'll change it to that. Perhaps we can continue this discussion in #273?

A PR to add this to the library would be welcome.

What is the purpose of exposing this information?

Is my understanding correct that this aggregation is only available with the paid Elasticsearch X-Pack license? Regardless, a PR for the same would be welcome. But we should call out...

A PR for that change is welcome

I feel extending the class is a much more rare use-case so would prefer to remove the reference from the declaration file. if possible, to reduce noise. Declaring these in...

This is not supported as of now. PRs are welcome.

Have removed the dependency on `util` in the recently released [`v2.17.0`](https://github.com/sudo-suhas/elastic-builder/releases/tag/v2.17.0). Closing this issue.