ShopOnline-Web-App icon indicating copy to clipboard operation
ShopOnline-Web-App copied to clipboard

1. For header and footer, i will remove it from the index.html and lo…

Open Ziyeetieu opened this issue 3 years ago • 3 comments

I would like to do enhancement for this project. Below are my thoughts for these enhancements:

  1. For header and footer, i will remove it from the index.html and login.html and import them into the index.html and login.html which allow the footer and header can be reuse on multiple html page for this project.
  2. For the registerCustomer.php, the if else statement which check for empty string, i will recommends to use 'empty($password)' instead of using password == " ".
  3. I would like to remove the customer registration form from the index.html and create a register.html which easier for maintanance but i will still keep the layout of the orginal website.

Ziyeetieu avatar Aug 07 '22 08:08 Ziyeetieu

Hey, welcome to this repository. We appreciate your efforts and contributions 🎉

github-actions[bot] avatar Aug 07 '22 08:08 github-actions[bot]

Hooray 🚀🎉 Your changes are now live and can now be seen in the preview version on https://shoponline-web.000webhostapp.com/pull_request/

github-actions[bot] avatar Aug 07 '22 08:08 github-actions[bot]

Will review and get back to you

san-coding avatar Aug 07 '22 13:08 san-coding