Setup Continuous Deploys

[sudara]

I keep merging and holding onto deploys so I can monitor when they go out, etc.

The downside is that code sits longer on master as it waits to be batched up. Also deploys carry higher risk since they are happening less frequently.

To implement:

• [ ] Figure out what service will trigger the deploy (probably circle ci)
• [ ] Make Percy blocking so we don't merge on Percy red
• [ ] Disable administrator from merging into master on red (currently I impatiently merge stuff that I "know" should be green and often isn't
• [ ] Think about requiring 1 code review approval before merge, and sudara shifts away from being The Guy That Merges Things to someone who approves, and the PR creator now has the option to merge and watch deploy (checks production, monitors #errors_and_deploys in slack)

[sudara]

@Manfred @innatewonderer @ofsound Thoughts or objections?

[ofsound]

I have no objections, but I generally am not doing anything with master, including merging other branches into it.

[Manfred]

I wouldn't make review required, we're all adults here and a small team. I'm fine with automated deploys so long as they stay visible and we know when they happen.

[sudara]

@ofsound This would give you the opportunity to ship code/fixes directly to production without waiting on me to merge, assuming specs and Percy pass.

@Manfred yeah, makes sense to me. Seems like +1 would be an unnecessary barrier. But the main point is if I approve and don’t merge, it’s an explicit signal that the PR author can merge/deploy assuming they are monitoring the changes going out.

[innatewonderer]

@sudara Is Merge Now only allowed/visible for contributors of the repo?

I actually don't mind Review Required for a larger team, but you definitely might get stuck one day in the middle of the night with some urgent hot-fix and no one awake :)

I'm all for setting up automatic deployments... But as with any great power... what if something goes wrong? I can deploy but I cannot fix anything if it goes wrong (besides reverting the change and merging again of course). Does @Manfred have access to our production env? Something to think about.

[Manfred]

Why would anyone be using the website in the middle of the night? 😄 But yeah, it makes sense to figure out a small team of people that might be able to fix these kinds of things.

Is Merge Now only allowed/visible for contributors of the repo?

I don't have admin access to the repository, but I can currently merge all PRs.