Arduino-Makefile icon indicating copy to clipboard operation
Arduino-Makefile copied to clipboard

Fix renaming PRODUCT and MANUFACTURER for Caterina devices like leonardo

Open G33kLabs opened this issue 5 years ago • 3 comments

It works with that in the Makefile (all without quotes) :

USB_MANUFACTURER = MANUFACTURER_NAME
USB_PRODUCT = PRODUCT_NAME

G33kLabs avatar Jul 13 '19 18:07 G33kLabs

this seems to break cores that actually use these settings e.g. the adafruit ones, where they use quotes:

feather32u4.build.usb_product="Feather 32u4"
feather32u4.build.usb_manufacturer="Adafruit"

the makefile without your patch works fine if you also use quotes, which you should do anyway as the strings may have spaces:

USB_PRODUCT = "product with spaces"

sej7278 avatar Aug 25 '19 13:08 sej7278

Ok, will check you that tomorrow with electronics near.

G33kLabs avatar Aug 25 '19 16:08 G33kLabs

@G33kLabs

Did you get a chance to check it with the real hardware?

sudar avatar Sep 03 '20 02:09 sudar