sp1 icon indicating copy to clipboard operation
sp1 copied to clipboard

Proofs created using different ELF files still pass with client.verify(ELF, proof)

Open Levike34 opened this issue 1 year ago • 2 comments

Steps to reproduce:

  1. Create proof using fibonacci example and write to file "proof-with-io.json"
  2. Change fibonacci example to another program, ex) change the addition to multiplication to generate NEW_ELF
  3. Pass NEW_ELF and load old proof from file from no. 1: client.verify(NEW_ELF, &proof).expect("verification failed)

This always returns (). I think this should return true/false, and this case above should return false

Levike34 avatar Apr 25 '24 08:04 Levike34

Hey @Levike34, thanks for raising this! Your issue be resolved in the following PR: https://github.com/succinctlabs/sp1/pull/580

We are in the process of updating our SDK API's & they should be more stable soon.

ratankaliani avatar Apr 26 '24 02:04 ratankaliani

@ratankaliani now I cannot get it to work at all, it always fails on client.setup. It fails with 'Segmentation Fault', or 'Invalid input vecs for input stream' in my warp server setup. It was working before this new format.

Levike34 avatar Apr 30 '24 02:04 Levike34