utxo-workshop icon indicating copy to clipboard operation
utxo-workshop copied to clipboard

Adjust startercode branch to be in line with master

Open apopiak opened this issue 5 years ago • 4 comments

People were having trouble compiling the startercode branch of the utxo-workshop here: https://github.com/paritytech/substrate/issues/7256 Adjusted the branch to be in line with the master branch.

apopiak avatar Nov 05 '20 14:11 apopiak

If you're bringing the video / workshop part of this up to speed, I highly recommend referencing a tag in the new videa rather than a branch like last time.

The reason is that when this PR gets merged the old video will talk about a branch that no longer points where it pointed when the video was recorded.

JoshOrndorff avatar Nov 05 '20 14:11 JoshOrndorff

Well I was just trying to bring this branch to an equivalent state to master so that people would be able to compile it again and work from it. I'm not planning on updating the video for now. Would actually really appreciate if @nczhu could chime in on how to proceed :-)

apopiak avatar Nov 05 '20 15:11 apopiak

Any updates on adjusting the branch to be in line with the master branch? Thanks!

fiexer avatar Nov 15 '20 20:11 fiexer

Hello, thanks for creating this branch but I met some issue here

OS: mac Big Sur 11.2.3 rustc: rustc 1.53.0 (53cb7b09b 2021-06-17) cargo: cargo 1.53.0 (4369396ce 2021-04-27)

when I run cargo check on this branch, I got following error:

Checking primitive-types v0.7.2 error[E0282]: type annotations needed --> /Users/zhangyouxin/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9 | 541 | let accuracy = P::ACCURACY.saturated_into(); | ^^^^^^^^ consider giving accuracy a type ... 1595 | / implement_fixed!( 1596 | | FixedI64, 1597 | | test_fixed_i64, 1598 | | i64, ... | 1601 | | "Fixed Point 64 bits signed, range = [-9223372036.854775808, 9223372036.854775807]", 1602 | | ); | |__- in this macro invocation | = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0282]: type annotations needed --> /Users/zhangyouxin/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9 | 541 | let accuracy = P::ACCURACY.saturated_into(); | ^^^^^^^^ consider giving accuracy a type ... 1604 | / implement_fixed!( 1605 | | FixedI128, 1606 | | test_fixed_i128, 1607 | | i128, ... | 1611 | | [-170141183460469231731.687303715884105728, 170141183460469231731.687303715884105727]_", 1612 | | ); | |__- in this macro invocation | = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0282]: type annotations needed --> /Users/zhangyouxin/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9 | 541 | let accuracy = P::ACCURACY.saturated_into(); | ^^^^^^^^ consider giving accuracy a type ... 1614 | / implement_fixed!( 1615 | | FixedU128, 1616 | | test_fixed_u128, 1617 | | u128, ... | 1621 | | [0.000000000000000000, 340282366920938463463.374607431768211455]_", 1622 | | ); | |__- in this macro invocation | = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 3 previous errors

For more information about this error, try rustc --explain E0282. error: could not compile sp-arithmetic

To learn more, run the command again with --verbose. warning: build failed, waiting for other jobs to finish...

zhangyouxin avatar Jun 21 '21 01:06 zhangyouxin