substrate-node-template icon indicating copy to clipboard operation
substrate-node-template copied to clipboard

Update docker compose, and run scripts

Open nuke-web3 opened this issue 4 years ago • 8 comments

#212 is older, but reveals that the docker integrations are likely stale and broken. We should either remove these, or update - ideally tested in CI here as well. Possibly there is some upstream tooling we can use for this? As the template is used upstream already for the release pipeline IIUC.

nuke-web3 avatar Sep 07 '21 15:09 nuke-web3

Maybe close that merged issue?

kamikazebr avatar Oct 14 '21 03:10 kamikazebr

IMO a docker/docker-compose based setup is much needed. Not everyone has a local working Rust setup, neither should be required to. Offering a working out-of-the-box docker-based solution is a must.

koslib avatar Oct 17 '21 20:10 koslib

#235 was not a fix. I simply have not checked the docker functionality - open to have others give it a test, I suspect there few changes (if any) needed for latest reference:

  • https://github.com/paritytech/substrate/tree/master/docker
  • https://github.com/paritytech/substrate/blob/master/.maintain/docker/substrate.Dockerfile
  • https://github.com/paritytech/substrate/blob/master/.maintain/local-docker-test-network/docker-compose.yml
  • https://github.com/paritytech/substrate/blob/master/bin/node-template/docker-compose.yml

nuke-web3 avatar Oct 17 '21 21:10 nuke-web3

Most of the links posted above also contain non functional manifests.

Example 1: this link https://github.com/paritytech/substrate/blob/master/bin/node-template/docker-compose.yml results in a path error.

Example 2: this link https://github.com/paritytech/substrate/tree/master/docker indicates this as an option

docker run --rm -it parity/substrate node-template --version

however this spits back

❯ docker run --rm -it parity/substrate node-template --version
error: Found argument 'node-template' which wasn't expected, or isn't valid in this context

That's why I think a general revamp and cleanup of all docker-related examples is needed. It's confusing for a starter.

koslib avatar Oct 18 '21 09:10 koslib

Agreed. Let's fix these upstream and update here after: https://github.com/paritytech/substrate/issues/10051

nuke-web3 avatar Oct 18 '21 14:10 nuke-web3

@NukeManDan can I pick this up?? I had a hard time setting this project manually from installing rust till all :P should give this a go..

muddlebee avatar Apr 06 '22 20:04 muddlebee

Sure!! @muddlebee I would say we have you update things here, but really they should land upstream in substrate itself, so please open a PR here, and @ me but expect to migrate upstream once in a good place. Feel free to DM me https://matrix.to/#/@dan.shields:matrix.parity.io if you need anything along the way :rocket:

nuke-web3 avatar Apr 20 '22 19:04 nuke-web3

PS C:\Users\georgiosd\Documents\substrate-node-template> docker-compose -f .\docker-compose.yml up
Starting node-template ... done
Attaching to node-template
node-template | error: failed to parse manifest at `/var/www/node-template/node/Cargo.toml`
node-template |
node-template | Caused by:
node-template |   failed to parse the `edition` key
node-template |
node-template | Caused by:
node-template |   this version of Cargo is older than the `2021` edition, and only supports `2015` and `2018` editions.
node-template exited with code 101

Any ideas? :)

EDIT: updating the image label to production works better :)

georgiosd avatar Jun 28 '22 13:06 georgiosd

Any changes to the source on this repo should be made upstream https://github.com/paritytech/substrate/tree/master/bin/node-template :pray:

nuke-web3 avatar Nov 19 '22 20:11 nuke-web3