substrate-docs icon indicating copy to clipboard operation
substrate-docs copied to clipboard

Parallel chain conversion documentation, missing an important parameter description.(MILLISECS_PER_BLOCK/SLOT_DURATION)

Open 99Kies opened this issue 3 years ago • 0 comments

Is there an existing issue?

  • [X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • [X] This is not a support question.

Content request

https://docs.substrate.io/how-to-guides/v3/parachains/convert/ There is an important omission about parachains convert.

/// This determines the average expected block time that we are targeting.
/// Blocks will be produced at a minimum duration defined by `SLOT_DURATION`.
/// `SLOT_DURATION` is picked up by `pallet_timestamp` which is in turn picked
/// up by `pallet_aura` to implement `fn slot_duration()`.
///
/// Change this to adjust the block time.
pub const MILLISECS_PER_BLOCK: u64 = 6000;

// NOTE: Currently it is not possible to change the slot duration after the chain has started.
//       Attempting to do so will brick block production.
pub const SLOT_DURATION: u64 = MILLISECS_PER_BLOCK;

This parameter is not mentioned in the documentation, This parameter is a very important parameter for parallel chain conversion. If the parameter is not set to 12000, the collator will can't poll blocks. https://github.com/substrate-developer-hub/substrate-node-template/blob/main/runtime/src/lib.rs#L114 https://github.com/substrate-developer-hub/substrate-parachain-template/blob/main/runtime/src/lib.rs#L186

Are you willing to help with this request?

Yes!

99Kies avatar Apr 13 '22 08:04 99Kies