substrate-docs icon indicating copy to clipboard operation
substrate-docs copied to clipboard

Can't find updated mint-token pallet

Open anishnaik opened this issue 3 years ago โ€ข 4 comments

Is there an existing issue?

  • [X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • [X] This is not a support question.

Content request

Hello, I am trying to practice with Substrate and was looking for the pallet associated with this mint-token tutorial

However, the link to the pallet goes to an outdated + archived version.

I am having a lot of errors that I am unable to debug because of the conflicting documentation and associated code in the outdated repo.

Are you willing to help with this request?

Yes!

anishnaik avatar Aug 03 '22 16:08 anishnaik

@sacha-l , I did a quick sanity check and the old example (v3) does compile. How much work would it be to update/create a new version of the example? I thought at first we might be able to just swap out Cargo.toml files to get new dependencies, but it seems that there's a little more to it than that. If it's too much effort, don't sweat it. I'm just checking in case you know some simple fix to get this working again.

lisa-parity avatar Aug 16 '22 21:08 lisa-parity

It wouldn't be that much work, though we would need to create a new home for example pallets like that in our docs org. Right now, as @anishnaik points out the mint-token pallet lives in a read-only archived repo.

That said, as I'm looking into this I question the actual value that this guide provides. I liked it originally because its meant to be an initiation for new comers and the simplicity of what it does makes it a good starting point for complete beginners: just using a storage map to map accounts to some quantity of type Balance. And users learn to include a minting and transfer function. However, I fear that its simplicity may be misleading and raise questions (e.g. the T::Balance type).

I suggest either we rework it as is (and possibly make it more of a tutorial) or rewrite the guide completely to focus on one or the other between:

  • Basic patterns for using storage maps and their APIs
  • Or, using different Balance and Currency configurations to handle token minting

What do you think?

sacha-l avatar Aug 17 '22 21:08 sacha-l

@sacha-l thank you for your response. I think this is a good tutorial for people who are migrating from a different chain like Ethereum. The idea of tokens is familiar to people from other ecosystems and this tutorial/guide can aid in providing that bridge. I do believe that an additional level of complexity would help in making improvements to this tutorial worthwhile. A full "ERC20-like" tutorial would be cool. Additionally the T::Balance aspect threw me off but explanations of that kind of stuff is what will help newcomers understand the nuances of Substrate development. The interoperability of various pallets is something I think should be touched upon more in the documentation (but that besides the point ๐Ÿ˜„).

anishnaik avatar Aug 18 '22 15:08 anishnaik

Have you had a look at this tutorial: https://docs.substrate.io/tutorials/smart-contracts/build-a-token-contract/ It uses ink! and the contracts pallet, buโ€  you might find it interesting to try.

On Thu, 18 Aug 2022 at 08:57, anishnaik @.***> wrote:

@sacha-l https://github.com/sacha-l thank you for your response. I think this is a good tutorial for people who are migrating from a different chain like Ethereum. The idea of tokens is familiar to people from other ecosystems and this tutorial/guide can aid in providing that bridge. I do believe that an additional level of complexity would help in making improvements to this tutorial worthwhile. A full "ERC20-like" tutorial would be cool. Additionally the T::Balance aspect threw me off but explanations of that kind of stuff is what will newcomers understand the nuances of Substrate development. The interoperability of various pallets is something I think should be touched upon more in the documentation (but that besides the point ๐Ÿ˜„).

โ€” Reply to this email directly, view it on GitHub https://github.com/substrate-developer-hub/substrate-docs/issues/1360#issuecomment-1219664408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7T7PNDRVYN6U5U7UKF77TVZZMM5ANCNFSM55PM4T2A . You are receiving this because you commented.Message ID: @.***>

-- Parity Technologies is a limited company registered in England and Wales with registered number 09760015 and registered office at c/o Ignition Law, 1 Sans Walk, London, England, EC1R 0LT. This message is intended solely for the addressee(s) and may contain confidential information. If you have received this message in error, please notify us, and immediately and permanently delete it. Do not use, copy or disclose the information contained in this message or in any attachment. For information about how we process data and monitor communications please see our Privacy policy (https://www.parity.io/privacy/ https://www.parity.io/privacy/)and for terms of use please see our Terms of Use policy (https://www.parity.io/terms/ https://www.parity.io/terms/).

lisa-parity avatar Aug 18 '22 16:08 lisa-parity