substrate-docs icon indicating copy to clipboard operation
substrate-docs copied to clipboard

Runtime storage best practices - Verify First Write Last Requires Additional Info Since Polkadot-v0.9.25

Open timurguvenkaya opened this issue 3 years ago • 0 comments

Is there an existing issue?

  • [X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • [X] This is not a support question.

Content request

Section: https://docs.substrate.io/main-docs/build/runtime-storage/ (Verify First, Update Last)

In substrate polkadot-v0.9.25 branch (https://github.com/paritytech/substrate/tree/polkadot-v0.9.25) #[transactional] macro got deprecated since it is now default behavior (https://github.com/paritytech/substrate/pull/11546 & https://github.com/paritytech/substrate/pull/11431). So now, even if verification happens after storage update, the state won't persist. It will get reverted on Err. Hence, it makes sense to update that section according to new updates. It is still best practice to follow, but it needs updated information.

Are you willing to help with this request?

Yes!

timurguvenkaya avatar Jul 02 '22 17:07 timurguvenkaya