Minor API and doc updates

Open gavento opened this issue 7 years ago • 2 comments

Work in progress update on Attributes.

Waits on internal attributes discussion and cleaup.

Mar 29 '18 14:03 gavento

Great work!

Just two comments:

In the current version, there is no finish_time in task info, but there is duration that contains duration of the task in milliseconds. (Also start_time is actually called only start). (See AttributeInfo in instance.rs)
Info of data object is not implemented yet; however do we really need to store finish_time and worker there? It should be identical as for the creator task.

I have no strong opinion on naming attributes, but we should put the documentation and implementation to the same state, maybe by changing docs, maybe by changing the implementation.

Mar 29 '18 22:03 spirali

Is this still relevant or we can close it without merge after introducing new attributes?

Jun 14 '18 21:06 spirali