substancelab
add rubocop as a development dependency
Seems like a shame to have defined rubocop config (and implemented rubocop changes) and not enforce it.
I've pinned the version of rubocop to the latest version to prevent arbitrary correctness changes.
Thank you so much for contributing.
We run Rubocop via Code Climate, though, (see https://codeclimate.com/github/substancelab/route_downcaser/pull/47 for an example). I wonder if it is worth running it on Travis as well?
Ah ok, I didn't see that. But it would be helpful to make it a development dependency pinned to the version being used. (just to make it easier to develop on). Shall I adjust the PR to remove travis and keep the dev dependency? Or if you're not convinced, you can just close it :)
I am toying with the idea of switching to https://github.com/testdouble/standard instead of raw Rubocop. It would require us to not rely on Code Climate, but that's not a dealbreaker for me.
What do you think of this instead?
I don't see a problem with testdouble/standard -- the standards seem more sensible than rubocop defaults.
And in terms of moving the rubocop from codeclimate to travis -- I would generally prefer this as I feel like a codeclimate fail is advisory (and needs informed judgement) whereas rubocop fail (like test suite fail) tend to be more absolute.