airport icon indicating copy to clipboard operation
airport copied to clipboard

update to latest seaport?

Open grncdr opened this issue 13 years ago • 4 comments

Are there any plans to update airport to work with the latest version of seaport? The current version crashes seaport servers whenever it connects, and I'm not sure how much of airports functionality is obsoleted by the newer clustering support in seaport.

Here is an example seaport crash, this happens every time the example airport server (beep.js) reconnects:

$ seaport listen 9090
seaport listening on :9090

.../seaport/node_modules/crdt/node_modules/scuttlebutt/index.js:197
    sources[source] = ts
                    ^
TypeError: Cannot set property '5C77ECC5946B768E835585CE' of undefined
    at Doc.onUpdate (.../seaport/node_modules/crdt/node_modules/scuttlebutt/index.js:197:21)
    at Doc.EventEmitter.emit (events.js:88:17)
    at Doc.applyUpdate (.../seaport/node_modules/crdt/doc.js:159:8)
    at didVerification (.../seaport/node_modules/crdt/node_modules/scuttlebutt/index.js:108:13)
    at Doc.sb._update (.../seaport/node_modules/crdt/node_modules/scuttlebutt/index.js:123:5)
    at Doc.sb.localUpdate (.../seaport/node_modules/crdt/node_modules/scuttlebutt/index.js:68:8)
    at Row.track (.../seaport/node_modules/crdt/doc.js:82:9)
    at Row.EventEmitter.emit (events.js:91:17)
    at Row._set (.../seaport/node_modules/crdt/row.js:45:8)
    at Row.set (.../seaport/node_modules/crdt/row.js:28:8)

grncdr avatar Jan 23 '13 01:01 grncdr

What you said. I just noticed the same, and it's a problem with a library I'm building. Airport just doesn't work out of the box if you have new seaport in your path instead of old.

abraxas avatar Feb 07 '13 19:02 abraxas

I've got a fork where I'm trying to do this. Most of the tests mostly pass right now (except that all the airport tests seem to randomly timeout on the box I'm devving in).

https://github.com/abraxas/airport (in case you're in too much of a hurry to wait for me to finish and a pull request)

abraxas avatar Feb 08 '13 19:02 abraxas

Also, anyone who wants to help, There's two tests failing on my updated version... and any knowledge would be appreciated.

abraxas avatar Feb 11 '13 13:02 abraxas

I see same error message on [email protected] event without airport — just by registering service from command-line using seaport command — https://github.com/substack/seaport/issues/27

dolphin278 avatar Mar 19 '13 11:03 dolphin278