subscribepro-magento2-ext icon indicating copy to clipboard operation
subscribepro-magento2-ext copied to clipboard
verified publisher icon subscribepro

Fix phpstan errors

Open garthbrantley opened this issue 2 years ago • 2 comments

PRs: #262, #264, #265, #54, #266 Separate PR for each level of phpstan compliance.

  • [x] Level 1
  • [x] Level 2
  • [x] Level 3
  • [x] Level 4

garthbrantley avatar Jun 17 '23 20:06 garthbrantley

@garthbrantley Added fixes for 4 levels of PHPStan errors. The config (phpstan.neon) has also been added to the module root dir. Instructions for using PHPStan were added to the Readme file.

Fixed scope for DataObject in the library (separate pull request)

eugene-shab avatar Dec 20 '23 14:12 eugene-shab

@eugene-shab Still needs more work. We want to pass:

  • bin/analyze --level=4 src/app/code/Swarming/SubscribePro
  • when the extension is installed inside Mark Shust docker stack

garthbrantley avatar Jan 17 '24 17:01 garthbrantley