subql icon indicating copy to clipboard operation
subql copied to clipboard

Update table creation on schema migration

Open bz888 opened this issue 1 year ago • 0 comments

Description

Schema migraiton should be an autonomous action that should be in one transaction Hence, we can not use sequelize.sync(), as if migration were to fail, table creation would still be executed

Tests on

  • Cyclic schema
  • Historical (complex schema, multiple relationals)
  • Non-historical (complex schema, multiple relationals)
  • QueryGenerators

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist

  • [x] I have tested locally
  • [x] I have performed a self review of my changes
  • [ ] Updated any relevant documentation
  • [ ] Linked to any relevant issues
  • [x] I have added tests relevant to my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] My code is up to date with the base branch
  • [x] I have updated relevant changelogs. We suggest using chan

bz888 avatar Feb 05 '24 09:02 bz888