subql icon indicating copy to clipboard operation
subql copied to clipboard

Store order by

Open stwiname opened this issue 1 year ago • 1 comments

Description

The store getBy methods don't currently support specifying the order and will always use ASC order.

We should add to the options for these methods to specify the order "ASC" | "DESC". It should be optional and retain the default order to not be a breaking change

stwiname avatar Nov 05 '23 20:11 stwiname

@stwiname I am interested in working on this issue. Please assign it to me.

Sanyam-jain30 avatar Jan 12 '24 15:01 Sanyam-jain30

@Sanyam-jain30 feel free to start this and make a PR when ready.

stwiname avatar Feb 23 '24 01:02 stwiname

@stwiname can we run the code in Windows?

Sanyam-jain30 avatar Feb 28 '24 04:02 Sanyam-jain30

It should run on Windows, although we don't regularly develop on windows

stwiname avatar Mar 04 '24 02:03 stwiname

I am unable to set it up on windows, @stwiname can you please assign it to somebody with a Mac, sorry for the inconvenience.

Sanyam-jain30 avatar Mar 10 '24 10:03 Sanyam-jain30

Hey @stwiname I am ready to pick this up!

singulart avatar Mar 27 '24 13:03 singulart