subql icon indicating copy to clipboard operation
subql copied to clipboard

Validate blockHeight argument

Open spitko opened this issue 3 years ago • 1 comments

Fixes #1124

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist

  • [x] I have tested locally
  • [x] I have performed a self review of my changes
  • [x] Updated any relevant documentation
  • [x] Linked to any relevant issues
  • [x] I have added tests relevant to my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] My code is up to date with the base branch

spitko avatar Jul 17 '22 18:07 spitko

Hi @spitko I wonder if there is a better approach for this, current approach will need run additional query for to get lastProcessedHeight in order to make comparison, this means we will have extra consumption for each query.

Is that possible to merge the comparison query and original query into one? Thanks

jiqiang90 avatar Jul 17 '22 23:07 jiqiang90