subo icon indicating copy to clipboard operation
subo copied to clipboard

add Cloudflare deployer

Open xtuc opened this issue 3 years ago • 3 comments

Originally reviewed in https://github.com/suborbital/subo/pull/229

xtuc avatar Mar 29 '22 10:03 xtuc

Looks like the failed lint is at builder/prereq_test.go:63:9. If you have golangci-lint installed you can run make lint from the project root. It's unfortunate that CI doesn't actually say what failed.

WARN [linters context] gci: `local-prefixes` is deprecated, use `sections` and `prefix(github.com/suborbital)` instead.
builder/prereq_test.go:63:9: err declared but not used (typecheck)
			got, err := tt.prereq.GetCommand(tt.r)

danielledeleo avatar Apr 13 '22 15:04 danielledeleo

@jagger27 I can see image

but I didn't change that file and err is actually used bellow.

xtuc avatar Apr 13 '22 15:04 xtuc

Hi @xtuc, sorry for the delay. Could you try pulling in the latest main? The linter is being a bit aggressive here (we missed it because this specific check is disabled in go1.18).

danielledeleo avatar Apr 19 '22 19:04 danielledeleo