Directive variable conflicts with imported package name

Open javorszky opened this issue 3 years ago • 2 comments

Here:

package: https://github.com/suborbital/subo/blob/main/builder/context/buildcontext.go#L11
variable: https://github.com/suborbital/subo/blob/main/builder/context/buildcontext.go#L72

They shouldn't have the same name. It's down to shadowing rules to figure out what you mean by directive, which can be confusing, and can lead to unexpected bugs.

Feb 02 '22 11:02 javorszky

Hey @javorszky, I would like to know about this issue, now this file is not present?

Mar 29 '22 13:03 yashikajotwani12

https://github.com/suborbital/subo/blob/main/project/context.go#L75 that functionality was moved here

Mar 29 '22 14:03 javorszky

That function doesn't exist at the moment, so closing for now. Seems resolved.

Nov 22 '22 02:11 arbourd