subnub
Support for custom S3 endpoint
Adds custom S3 endpoint for configuration and personal account. If the endpoint is not specified, it will use the default AWS S3 endpoint. This way current configuration should still work even if the endpoint is not defined.
Fixes #30 Custom S3 endpoint
Thank you!! I will review/test this once I get the chance. This is awesome :)
Hey! Just wanted to give you a quick update. So I am doing some testing, and for the most part everything seems to work. But, there does seem to be one issue that I have discovered so far. It seems like in the actual setup if the host of myDrive chooses Amazon S3 instead of the Filesystem or MongoDB. And then they also add their own personal S3 account in the settings, it seems to cause an upload conflict. It seems like the user can still upload to their own personal S3 account, but if they attempt to upload to just myDrive normally it will throw an error. It seems like only uploads are effected by this, for example photos, videos, and downloading files works correctly. If the host where to choose the Filesystem and then their personal S3 account in settings it still seems to work correctly.
This bug doesn't seem to be present in the master branch, so I am guessing its something that was added in this pull request. I am attempting to track down exactly why this is happening... but its quite an odd issue.
I will keep looking into it, just wanted to let you know so you didn't think I forgot about this :) @pvharmo
@subnub A possible solution could be some kind of detection to see if there's a conflict and then have some kind of dialog to ask "where do you want to upload this? " and have "Local" (which would be the main S3) or "Personal S3" and they could pick whatever option they're going for.
@HarrisonMayotte That is already how it works, there is a drop down menu at the top left where you can select to upload to myDrive (Local S3), Personal S3, or Google Drive. The issue isn't the user not being able to specify where they are uploading, or else it wouldn't work for FS/MongoDB. The issue is odd, and seems to only appear when using minIO/S3 is combination with adding your own personal S3 account. For some you cannot upload to just myDrive (the local S3), but only their personal S3.
This issue didn't appear earlier if you have a S3 set as the local and add a personal account, so there must be something that changed in this commit that I haven't been able to track down yet.
I appreciate the thought tho!
Hi @subnub, sorry for not giving any updates on this. I recently tried to fix it, but I couldn't reproduce the issue. I had been able to reproduce it in March. I was wondering if you still have this error on your side? The only change I made was deleting the node_modules folder and reinstall.