LSP icon indicating copy to clipboard operation
LSP copied to clipboard

Prepare for upgrade of bracex and wcmatch libraries

Open deathaxe opened this issue 1 year ago • 4 comments

If the dust has settled with transitioning to python 3.8, two PRs are prepared to upgrade

by shipping them directly from pypi for python 3.8

I already installed them manually and haven't seen any negative impacts so far. Maybe someone more involved could double check for possible incompatibilities, especially as version numbers of wcmatch differ significantly.

deathaxe avatar Apr 20 '24 12:04 deathaxe

bracex is used by wcmatch wcmatch still exposes the same API that LSP uses. The behavior might be different however.

Do you maybe have a guide on how to install those deps locally?

predragnikolic avatar Apr 20 '24 19:04 predragnikolic

You can download the whl files and directly extract them into ST's Lib/python38 folder.

  • https://pypi.org/project/bracex/#files
  • https://pypi.org/project/wcmatch/#files

Make sure to remove the currently installed libraries' folders first.

deathaxe avatar Apr 20 '24 21:04 deathaxe

I will start with testing this.

predragnikolic avatar May 03 '24 08:05 predragnikolic

If someone want to also try to test it out. You would need to keep the bracex-2.1.1.dist-info and wcmatch-1.2.1.dist-info and change the INSTALLER to not point to Package Control

predragnikolic avatar May 03 '24 08:05 predragnikolic

I have't run into any issues in the past two weeks.

predragnikolic avatar May 20 '24 15:05 predragnikolic

I will close this issue, because there are no code changes that needs to be done on the LSP side, and I haven't noticed any regressions.

Feel free to reopen this is you think otherwise.

predragnikolic avatar May 20 '24 16:05 predragnikolic