LSP icon indicating copy to clipboard operation
LSP copied to clipboard

Emmet preview not working with LSP-html

Open LDAP opened this issue 2 years ago • 5 comments

Describe the bug Emmet normally shows a preview of complex abbreviations. When LSP-html is active, the preview only flashes shortly or is missing completely.

To Reproduce Steps to reproduce the behavior:

  1. Install Emmet, LSP, LSP-html
  2. Open an HTML file
  3. Type a complex abbreviations

Expected behavior The preview should be displayed

Environment (please complete the following information):

  • OS: Arch Linux
  • Sublime Text version: 4129
  • LSP version: 1.16.1
  • Language servers used: LSP-html

Additional context none

LDAP avatar Apr 06 '22 21:04 LDAP

Did you also open an issue at the emmet package?

rwols avatar Apr 06 '22 22:04 rwols

I did not. Wasn't really sure if it is a LSP or Emmet Bug (or both).

LDAP avatar Apr 06 '22 22:04 LDAP

Emmet uses view.show_popup to display the completion. I don’t know what triggers the popup to disappear.

rwols avatar Apr 06 '22 22:04 rwols

Can you enable sublime.log_commands(True) in the console and see if there is any correlation there?

rwols avatar Apr 06 '22 22:04 rwols

Nothing correlated is logged.

But I should mention that LSP complains that the file isn't inside window folders. That is the only message logged, besides deletes and character inserts.

LDAP avatar Apr 06 '22 22:04 LDAP

Just because it wasn't pointed out in the previous discussion yet; I believe this happens because of this line https://github.com/sublimelsp/LSP/blob/36b0bc9a8b772569f06654ab4cae58e6af7f3cf8/plugin/documents.py#L577 which is called after each buffer modification if the language server supports signature help (and has triggerCharacters defined).

jwortmann avatar Sep 22 '23 17:09 jwortmann

How can I reproduce this @LDAP ?

For me this looks like its working as expected Screencast from 2023-09-24 11-42-15.webm

LSP v1.25.0

predragnikolic avatar Sep 24 '23 09:09 predragnikolic

Haven't used Emmet for a while. Might be fixed in the meantime? I can't reproduce it either.

We can close and reopen if the issue occurs in the future.

LDAP avatar Sep 24 '23 09:09 LDAP