sublime_text icon indicating copy to clipboard operation
sublime_text copied to clipboard

[Themes] `CommandInputHandler`'s preview and phantoms always have the `file_dark` luminosity attribute.

Open AmjadHD opened this issue 3 years ago • 5 comments

Description of the bug

html_control class has the file_dark attribute always set. image Here is the control tree of the preview with the Adaptive theme:

control tree at: 586.5,215.5
title_bar [file_light] pos: 0,0 size: 1366,728
    .bg=[230, 230, 230, 255]
    .fg=[77, 77, 77, 255]
    .style=light
 edit_window window [file_light] pos: 0,23 size: 1366,705
  grid_layout_control pos: 242,23 size: 1124,683
      .border_color=[230, 230, 230, 255]
      .border_size=2
   pane_container_control pos: 242,23 size: 1124,613
    control pos: 504,55 size: 600,390
     overlay_control command_palette pos: 504,55 size: 600,390
         .content_margin=[4, 4, 4, 4]
         .layer0.opacity=1
         .layer0.tint=[230, 230, 230, 255]
      html_control [file_dark] pos: 508,97 size: 592,344
    sheet_container_control pos: 242,57 size: 1124,579
        .layer0.opacity=1
     scroll_area_control [scrollable] pos: 242,57 size: 1124,579
      control pos: 242,57 size: 1109,579
       text_area_control sheet_contents [file_light, highlighted] pos: 242,-10169 size: 1109,66998
           .deleted_line_texture=36

Steps to reproduce

  1. Start ST in safe mode.
  2. Enable control tree logging.
  3. Run 'Arithmetic' from the command palette.
  4. paste x.

Expected behavior

the luminosity attribute should match window's.

Actual behavior

It doesn't.

Sublime Text build number

4126

Operating system & version

Windows 10

(Linux) Desktop environment and/or window manager

No response

Additional information

No response

OpenGL context information

No response

AmjadHD avatar Jan 03 '22 17:01 AmjadHD

Oups.

grafik

deathaxe avatar Jan 03 '22 18:01 deathaxe

It's html_control even for phantoms.

AmjadHD avatar Jan 07 '22 21:01 AmjadHD

@deathaxe, I believe this is a regression, you should add a label.

AmjadHD avatar Jan 31 '22 19:01 AmjadHD

Was this fixed for 4127 like #5125 ?

AmjadHD avatar Apr 21 '22 03:04 AmjadHD

@BenjaminSchaaf apologies for the ping, I wanted to bring to a dev's attention that this is a regression and should be fixed.

AmjadHD avatar Oct 20 '22 18:10 AmjadHD

Fixed in build 4139.

BenjaminSchaaf avatar Nov 09 '22 00:11 BenjaminSchaaf