Packages icon indicating copy to clipboard operation
Packages copied to clipboard

[Sublime] Add Syntax Test Results syntax

Open deathaxe opened this issue 1 year ago • 4 comments

This PR proposes to add a Sublime package with Sublime Syntax Test Results syntax definition for highlighting syntax test result outputs with regards to https://github.com/sublimehq/sublime_text/issues/3022.

Thoughts:

  1. A package named "Sublime" does not yet exist on package control.
  2. The package name is generic enough to potentially take more Sublime Text related syntax files.

Maybe more suitable alternative package names are appriciated.

Syntax definition is designed to highlight ST's default syntax test result output - despite the proposal in https://github.com/sublimehq/sublime_text/issues/3022, which addresses a reformatted output.

grafik

deathaxe avatar Feb 24 '24 09:02 deathaxe

I am definitely in favor of also reformatting the line display like in https://github.com/sublimehq/sublime_text/issues/3022#issuecomment-1937034498 because it is much easier to compare the expected selector and actual scope that way.

FichteFoll avatar Feb 24 '24 14:02 FichteFoll

  1. The package name is generic enough to potentially take more Sublime Text related syntax files.

Are you thinking of moving the file patterns? That makes sense to me if this folder is added.

michaelblyons avatar Feb 25 '24 19:02 michaelblyons

I didn't have certain syntaxes in mind - just found adding a package named Sublime Syntax Test Results with only one file/syntax inside rather too specific.

Not sure, what a good name for such ST related syntaxes would be.

Depending on how packages are finally built by sublimehq, I could also imagine creating a "Default" package in this repo. It however would require containing files to be added to "Default.sublime-package". Not sure if that's desirable.

deathaxe avatar Feb 25 '24 20:02 deathaxe

I would also guess that the Default package makes sense as a holder of various built-in functionality and as something that cannot/should not be disabled because it is referenced in other built-in parts. Iirc there used to be problems for people that disabled the package with the regular expression syntax for some reason, for example.

However, it raises the question of whether it can/should be included inside of this repo in that case.

FichteFoll avatar Feb 25 '24 20:02 FichteFoll

Closing as obsolete with regards to progress made in https://github.com/sublimehq/sublime_text/issues/3022.

deathaxe avatar Jul 23 '24 13:07 deathaxe