Packages icon indicating copy to clipboard operation
Packages copied to clipboard

[C#] named contexts for string content

Open michaelblyons opened this issue 2 years ago • 2 comments

What happened?

This is #3462 for C#:

[M]ake the context(s) pushed for strings with special highlighting into a named context instead of an anonymous one, so extendsed syntaxes can add additional special cases.

~~See-also: #3659 in case of conflicts~~ Edit: it's merged now. All good.

michaelblyons avatar May 02 '23 13:05 michaelblyons

I guess all syntaxes should be refactored to use named contexts primarily/only ideally with a common context naming scheme.

#3659 intents not to mess with current context naming scheme.

In the long term we should probably go through the syntax and refactor it after the scheme of Python. But honestly, there are probably other syntaxes of higher priority with regards to improving quality of highlighting..

deathaxe avatar May 02 '23 15:05 deathaxe

I guess all syntaxes should be refactored to use named contexts primarily/only ideally with a common context naming scheme.

https://github.com/sublimehq/Packages/pull/3659 intents not to mess with current context naming scheme.

Understood. I just wanted anyone who might start on this in the short term to know that they might be creating conflicts.

But honestly, there are probably other syntaxes of higher priority with regards to improving quality of highlighting..

Agreed. 🙂

michaelblyons avatar May 02 '23 16:05 michaelblyons