day_night_time_picker icon indicating copy to clipboard operation
day_night_time_picker copied to clipboard

Published 20 hours ago • verified publisher icon subhamayd2

Is there an option to be able to pick seconds too?

Open IsaiChristian opened this issue 2 years ago • 3 comments

If there isnt, WOuld you be interested in a pull request including it?

IsaiChristian avatar Sep 07 '22 23:09 IsaiChristian

Sounds good to me.. @TheGlorySaint thoughts on this?

subhamayd2 avatar Sep 08 '22 12:09 subhamayd2

Hey @IsaiChristian,

currently, there is no option about picking seconds. For what use case do you think this could and would be used that exactly that needs to have seconds? Feel free to post a PR, I'll have a look at that then.

@subhamayd2 Why not having. I can't think about a use case but someone definitely can have a use case for this.

TheGlorySaint avatar Sep 13 '22 14:09 TheGlorySaint

Well for me is that we are doing a trading journal were people have the option add their transactions manually, as we are focused on daytraders, some times 2 trades can happen in the same minute. this is just to save the info no too try to do anything programatically.

IsaiChristian avatar Sep 23 '22 19:09 IsaiChristian

Right now, the limitation that I found was that we are using TimeOfDay as the value, which doesn't have a second property. The alternative is to use DateTime as the value - now by doing this we lose the DayPeriod property (i.e. the am/pm). 😞

Including second would be a lot of change and refactoring. If you are willing to contribute to this, that would be helpful.

subhamayd2 avatar Feb 23 '23 08:02 subhamayd2

I have updated the picker to include seconds as well. It's available in the latest release.

subhamayd2 avatar Feb 23 '23 10:02 subhamayd2