noosphere icon indicating copy to clipboard operation
noosphere copied to clipboard

feat: Do not proactively create directories when creating spheres via CLI. Fixes #599

Open jsantell opened this issue 2 years ago • 4 comments

jsantell avatar Sep 19 '23 18:09 jsantell

Can you provide a rationale for the change? Maybe a test?

cdata avatar Sep 19 '23 18:09 cdata

Can you provide a rationale for the change? Maybe a test?

In #599, for early failures (like an invalid key), the SpherePaths initialization proactively creates all of the .sphere dirs., preventing follow up commands with the correct key, as the sphere dirs are no longer uninitialized. Added a test in noosphere/tests/cli.rs

jsantell avatar Sep 19 '23 18:09 jsantell

Thanks, I missed that the bug was in the title at first :+1:

cdata avatar Sep 19 '23 18:09 cdata

Test flake analysis

No flakes detected 🎉

status platform features toolchain
🟢 macos-13 test-kubo,headers stable
🟢 macos-13 test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers stable
🟢 windows-latest test-kubo,headers stable

github-actions[bot] avatar Oct 31 '23 20:10 github-actions[bot]