noosphere
noosphere copied to clipboard
feat: Do not proactively create directories when creating spheres via CLI. Fixes #599
Can you provide a rationale for the change? Maybe a test?
Can you provide a rationale for the change? Maybe a test?
In #599, for early failures (like an invalid key), the SpherePaths initialization proactively creates all of the .sphere dirs., preventing follow up commands with the correct key, as the sphere dirs are no longer uninitialized. Added a test in noosphere/tests/cli.rs
Thanks, I missed that the bug was in the title at first :+1:
Test flake analysis
No flakes detected 🎉
| status | platform | features | toolchain |
|---|---|---|---|
| 🟢 | macos-13 |
test-kubo,headers |
stable |
| 🟢 | macos-13 |
test-kubo,headers,rocksdb |
stable |
| 🟢 | ubuntu-latest |
test-kubo,headers,rocksdb |
stable |
| 🟢 | ubuntu-latest |
test-kubo,headers |
stable |
| 🟢 | windows-latest |
test-kubo,headers |
stable |