Sub-Store-Manager-Cli icon indicating copy to clipboard operation
Sub-Store-Manager-Cli copied to clipboard

前端不能更新,且丢失版本号

Open fzdy-zz opened this issue 1 year ago • 6 comments

image

fzdy-zz avatar Jul 04 '24 11:07 fzdy-zz

2.14.347是后端 上面一行是前端

cooip-jm avatar Jul 04 '24 13:07 cooip-jm

那你会不会看代码,前端就是不显示版本号,就是显示这样的,反馈就一张图,要不你自己改。


type FEVersionInfo struct {
	Sha string `json:"sha"`
}

func getFEVersion() (v string) {
	var info FEVersionInfo
	_, err := lib.HC.R().SetResult(&info).Get("https://api.github.com/repos/sub-store-org/Sub-Store-Front-End/commits/master")
	if err != nil {
		lib.PrintError("Failed to get versions info:", err)
	}
	return info.Sha
}

func (c *Container) SetLatestVersion() {
	switch c.ContainerType {
	case vars.ContainerTypeFE:
		c.Version = getFEVersion()[:7]

为啥用sha做version???

自己本地改一下算了

cooip-jm avatar Jul 04 '24 15:07 cooip-jm

image

https://github.com/sub-store-org/Sub-Store-Manager-Cli/blob/master/docker/version.go

/*
	type FEVersionInfo struct {
		Sha string `json:"sha"`
	}

	func getFEVersion() (v string) {
		var info FEVersionInfo
		_, err := lib.HC.R().SetResult(&info).Get("https://api.github.com/repos/sub-store-org/Sub-Store-Front-End/commits/master")
		if err != nil {
			lib.PrintError("Failed to get versions info:", err)
		}
		return info.Sha
	}
*/
func getFEVersionInfos() (json []ReleaseInfo) {
	_, err := lib.HC.R().SetResult(&json).Get("https://api.github.com/repos/sub-store-org/Sub-Store-Front-End/releases")
	if err != nil {
		lib.PrintError("Failed to get versions info:", err)
	}
	return
}

func getFEVersionStrs() (v []string) {
	for _, info := range getFEVersionInfos() {
		v = append(v, info.TagName)
	}
	return
}

func (c *Container) SetLatestVersion() {
	switch c.ContainerType {
	case vars.ContainerTypeFE:
		feVersions := getFEVersionStrs()
		if len(feVersions) == 0 {
			lib.PrintError("no Front versions found", nil)
			return
		}
		c.Version = feVersions[0]
	case vars.ContainerTypeBE:
		beVersions := getBEVersionStrs()
		if len(beVersions) == 0 {
			lib.PrintError("no BE versions found", nil)
			return
		}
		c.Version = beVersions[0]
	}
}

就不PR了,可能使用SHA有其它考量。

fzdy-zz avatar Jul 05 '24 07:07 fzdy-zz

最初的设计是总是使用最新版本的前端,就一直这样用了

DesnLee avatar Jul 06 '24 11:07 DesnLee