SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

[WIP] jBAY and BAY vortex generator model

Open maxi120 opened this issue 1 year ago • 3 comments

Proposed Changes

The current work implements the BAY and jBAY vortex generator source-term model using a jBAY cell selection method in the compressible and incompressible solver. The model allows to simulate triangular and rectangular vortex generators. The model is based of https://doi.org/10.4233/uuid:704d764a-6803-4cad-991f-45dc4ea38f6d.

PR Checklist

  • [ x ] I am submitting my contribution to the develop branch.
  • [ ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [ x ] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

maxi120 avatar Apr 27 '24 16:04 maxi120

Hi, Can you bring the external packages in your PR up to date? You probably missed a 'git submodule update --init' or something similar.

bigfooted avatar Apr 29 '24 07:04 bigfooted

Hi, Can you bring the external packages in your PR up to date? You probably missed a 'git submodule update --init' or something similar.

Thank you, should be updated now.

maxi120 avatar Apr 29 '24 10:04 maxi120

The source term is pretty simple but the feature as a whole is very intrusive on the code, even the mesh deformation is getting involved in this. Would it be viable to use the python wrapper to provide the source term?

pcarruscag avatar May 07 '24 14:05 pcarruscag