SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

[WIP] Standard initialization for Incompressible flows using thermodynamic_pressure and the Inc_Temperature_init

Open Cristopher-Morales opened this issue 1 year ago • 1 comments

Proposed Changes

With this pull request, we aim to initialize the fluid models based on the Ideal gas laws for incompressible flows in a standard way using the THERMODYNAMIC_PRESSURE($P_{op}$) and the INC_TEMPERATURE_INIT ($T_{init}$), the initial density is computed based on the ideal gas law :

$\rho_{init}= P_{op} / R T_{init}$

When the FLUID_MODEL is CONSTANT_DENSITY, the constant density must be given in the config file using the option DENSITY_CONSTANT, similar as it is done when viscosity, thermal conductivity and diffusivity models are chosen as constant.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X] I am submitting my contribution to the develop branch.
  • [X] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [X] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [ ] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Cristopher-Morales avatar Sep 20 '23 10:09 Cristopher-Morales

I am trying to find some time to think about how to do a bit of option-consolidation on the non-dimensionalization side and initialization is quite a bit linked to that process -> I hope to open a discussion with some more information and proposal soon -> And since this PR is looking to change the INC_DENSITY_INIT option which is part of that my request would be to maybe spare that option up to the conference (the init change to use thermodynamic pressure is a little more independent of that I think via pedros suggestion to mimic what we do for compressible flow atm)

TobiKattmann avatar Oct 16 '23 18:10 TobiKattmann