SU2
SU2 copied to clipboard
[WIP] fix volume names
Proposed Changes
For volume names, we assume that the filename is filename.ext and we strip the extension using find_last_of('.') But:
- This can lead to unwanted file stripping when you want the filename or folder to be volume.a
- We already mention in the documentation that the volume filename should be given without an extension
I think we should simply remove the find_last_of lines. There are more of those, for now I have simply removed the one connected to #2074
Related Work
Issue: #2074
PR Checklist
- [x] I am submitting my contribution to the develop branch.
- [x] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- [x] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- [ ] I have added a test case that demonstrates my contribution, if necessary.
- [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
There are some other find_last_of lines as well, if all filenames are supposed to be given without any file extension, then these should all be removed.
In principle sounds good, it will probably break lots of cases, optimization scripts and what not. We'll see, we are not leaving this inconsistent though, all or nothing.
In principle sounds good, it will probably break lots of cases, optimization scripts and what not. We'll see, we are not leaving this inconsistent though, all or nothing.
I agree.